Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokenomics] Preparation for proportional relay mining rewards based on difficulty #771

Merged
merged 64 commits into from
Sep 21, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Aug 29, 2024

Summary

No real business logic changes, but preparation + tests + helpesr + TODOs for #781.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

Olshansk and others added 30 commits August 15, 2024 21:39
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Redouane Lakrache <[email protected]>
@Olshansk Olshansk requested review from red-0ne and removed request for bryanchriswhite and adshmh September 20, 2024 00:01
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how this is taking form!

Left a small NIT but preemptively approving.

x/proof/keeper/proof_validation.go Outdated Show resolved Hide resolved
@red-0ne
Copy link
Contributor

red-0ne commented Sep 20, 2024

Regarding this test error
image

Adding a time.Sleep before event filtering should work around the issue

Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 771)
Grafana network dashboard for devnet-issue-771

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Sep 20, 2024
@Olshansk
Copy link
Member Author

Commenting out a single test that seems to be related to an architecture floating point issue that @red-0ne will addres..

Screenshot 2024-09-20 at 4 55 09 PM

Screenshot 2024-09-20 at 5 12 13 PM

@Olshansk Olshansk merged commit f7b5794 into main Sep 21, 2024
13 checks passed
@Olshansk Olshansk deleted the relay_mining_tests branch September 21, 2024 00:39
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
…egration-app

* pokt/main:
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
…nsfer-msg_period-param

* pokt/main:
  [Application] feat: app stake transfer (#743)
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
…rge/integration-app_x_transfer-period-base

* issues/799/refactor/integration-app:
  resolve: merge conflict
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
…' into issues/657/chore/app-transfer-period

* issues/657/merge/integration-app_x_transfer-period-base:
  resolve: merge conflict
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
…p' into issues/799/merge/integration-app_x_sup-stake-evts

* pokt/issues/799/refactor/integration-app:
  resolve: merge conflict
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
… issues/799/tests/params

* issues/799/merge/integration-app_x_sup-stake-evts:
  [Application] feat: app stake transfer (#743)
  resolve: merge conflict
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
… issues/799/tests/params

* issues/799/merge/integration-app_x_sup-stake-evts:
  resolve: merge conflict
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
bryanchriswhite added a commit that referenced this pull request Sep 23, 2024
…lier-stake-events

* issues/799/e2e/param-helpers:
  fix: add missing steps and update module name for moved param
  [Code Health] refactor: rename `ApplicationTransfer` msgs (#788)
  [Docs] Add operations documentation about proof submission fee (#806)
  [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815)
  [Application] feat: app stake transfer (#743)
  Empty commit
  [Tokenomics] Preparation for proportional relay mining rewards based on difficulty (#771)
  [Documentation] Change container names in the quickstart (#830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e on-chain On-chain business logic push-image CI related - pushes images to ghcr.io tokenomics Token Economics - what else do you need? utility
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants